Fixes #9. Update to version 2.0.1.

Andy4495 · Jan 10, 2023 · 301c6e7 · 301c6e7
1 parent 014bb76
commit 301c6e7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/LICENSE b/LICENSE
@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2018 - 2022 Andreas Taylor
+Copyright (c) 2018 - 2023 Andreas Taylor
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/README.md b/README.md
@@ -73,7 +73,7 @@ void loop() {
   // Write a byte to a device register: 
   myDevice.writeToRegister(regAddress, byte_to_write);
   // Read a byte from a device register: 
-  myDevice.readFromRegister(regAddress, &byte_to_read);
+  myDevice.readFromRegister(regAddress, byte_to_read);
 
   // Write several bytes to a device register:
   myDevice.writeToRegister(regAddress, buffer, 10);

diff --git a/library.properties b/library.properties
@@ -1,5 +1,5 @@
 name=SWI2C
-version=2.0.0
+version=2.0.1
 author=Andreas Taylor <[email protected]>
 maintainer=Andreas Taylor <[email protected]>
 sentence=Software I2C library.

diff --git a/src/SWI2C.cpp b/src/SWI2C.cpp
@@ -13,6 +13,7 @@
    07/27/2022 - Andy4495 - Support single-register devices (Issue #3)
    08/19/2022 - Andy4495 - Consistently use unsigned, fix-sized types where appropriate
                          - Add simpler, basic high-level methods
+   01/10/2023 - Andy4495 - Fix #9 (send NACK after reading byte from device)
 */
 
 #include "SWI2C.h"
@@ -137,6 +138,7 @@ int SWI2C::readFromDevice(uint8_t &data, bool sendStopBit) {
   writeAddress(1); // 1 == Read bit
   if (checkAckBit()) {stopBit(); return 0;} // Immediately end transmission and return 0 if NACK detected
   data = read1Byte();
+  checkAckBit(); // Controller needs to send NACK when done reading data
   if (sendStopBit) stopBit();
   return 1;  // Return 1 if no NACKs  
 }
@@ -267,6 +269,7 @@ int SWI2C::read1bFromDevice(uint8_t* data, bool sendStopBit){
   writeAddress(1); // 1 == Read bit
   if (checkAckBit()) {stopBit(); return 0;} // Immediately end transmission and return 0 if NACK detected
   *data = read1Byte();
+  checkAckBit(); // Controller needs to send NACK when done reading data
   if (sendStopBit) stopBit();
   return 1;  // Return 1 if no NACKs  
 }