Add tracking delegate and improve error handling #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[NFC-386] Add changes requested in PR
* [NFC-395] Add delegate for tracking NFC detection * NFC-395 Changes requested in PR * NFC-395 Add changes requested in PR
* Add more tracking for chip access phase * Bubble up parsed card access instad of raw data
josiprezic-mohemian
approved these changes
Dec 2, 2024
Comment on lines
+290
to
+300
| do { | ||
| trackingDelegate?.bacStarted() | ||
|
|
||
| try await doBACAuthentication(tagReader : tagReader) | ||
|
|
||
| trackingDelegate?.bacSucceeded() | ||
| } catch { | ||
| trackingDelegate?.bacFailed() | ||
|
|
||
| throw error | ||
| } |
There was a problem hiding this comment.
Consider removing empty lines here
Suggested change
| do { | |
| trackingDelegate?.bacStarted() | |
| try await doBACAuthentication(tagReader : tagReader) | |
| trackingDelegate?.bacSucceeded() | |
| } catch { | |
| trackingDelegate?.bacFailed() | |
| throw error | |
| } | |
| do { | |
| trackingDelegate?.bacStarted() | |
| try await doBACAuthentication(tagReader : tagReader) | |
| trackingDelegate?.bacSucceeded() | |
| } catch { | |
| trackingDelegate?.bacFailed() | |
| throw error | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Delegate
Add a tracking delegate for the
PassportReaderto track the detection of an NFC tag and the authentication processes (BAC and PACE).We added the tracking to gain insights into the duration of each step, depending on its completion status (success or failure).
Note: There are no breaking changes, since the default implementation of the tracking delegate in the
PassportReaderis empty.Error Handling
Add more detailed error handling to provide users better feedback on why the reading failed.
TimeOutErrorwhen the reader session timed outConnectionErrorinstead ofUnknown