Refactoring user ID list to send mails - refs BT#21648

AngelFQC · May 26, 2024 · 8472948 · 8472948
1 parent 0da3b71
commit 8472948
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/src/CoreBundle/State/MessageProcessor.php b/src/CoreBundle/State/MessageProcessor.php
@@ -11,6 +11,7 @@
 use ApiPlatform\Metadata\Post;
 use ApiPlatform\State\ProcessorInterface;
 use Chamilo\CoreBundle\Entity\Message;
+use Chamilo\CoreBundle\Entity\MessageRelUser;
 use Notification;
 
 final class MessageProcessor implements ProcessorInterface
@@ -45,19 +46,21 @@ private function saveNotificationForInboxMessage(Message $message): void
             $message->getSender()->getId()
         );
 
-        foreach ($message->getReceivers() as $receiver) {
-            $user = $receiver->getReceiver();
-
-            (new Notification())
-                ->saveNotification(
-                    $message->getId(),
-                    Notification::NOTIFICATION_TYPE_MESSAGE,
-                    [$user->getId()],
-                    $message->getTitle(),
-                    $message->getContent(),
-                    $sender_info,
-                )
-            ;
-        }
+        $userIdList = $message
+            ->getReceivers()
+            ->map(fn (MessageRelUser $messageRelUser): int => $messageRelUser->getReceiver()->getId())
+            ->getValues()
+        ;
+
+        (new Notification())
+            ->saveNotification(
+                $message->getId(),
+                Notification::NOTIFICATION_TYPE_MESSAGE,
+                $userIdList,
+                $message->getTitle(),
+                $message->getContent(),
+                $sender_info,
+            )
+        ;
     }
 }