Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Commit

Permalink
sync up namings
Browse files Browse the repository at this point in the history
  • Loading branch information
Andrey authored and Andrey committed Jul 25, 2023
1 parent 7fefe05 commit 61e74e7
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 8 deletions.
1 change: 0 additions & 1 deletion contracts/core/accounts/message.sol
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ library AccountMessages {
address registrarContract;
uint256 nextAccountId;
uint256 maxGeneralCategoryId;
LibAccounts.FeeSetting earlyLockedWithdrawFee;
}

struct StateResponse {
Expand Down
1 change: 0 additions & 1 deletion contracts/core/accounts/storage.sol
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ library AccountStorage {
uint32 nextAccountId;
uint256 maxGeneralCategoryId;
bool reentrancyGuardLocked;
LibAccounts.FeeSetting earlyLockedWithdrawFee;
}

struct Endowment {
Expand Down
8 changes: 4 additions & 4 deletions contracts/multisigs/CharityApplications.sol
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,11 @@ contract CharityApplications is MultiSigGeneric, StorageApplications, ICharityAp
* @notice propose a charity to be opened on Accounts
* @dev propose a charity to be opened on Accounts
* @param _application.Charity application
* @param _meta Meta (URL of Metadata)
* @param _metadata Metadata
*/
function proposeApplication(
AccountMessages.CreateEndowmentRequest memory _application,
bytes memory _meta
bytes memory _metadata
) public override {
require(proposals[proposalCount].proposer == address(0), "Proposal already exists");
require(
Expand All @@ -135,12 +135,12 @@ contract CharityApplications is MultiSigGeneric, StorageApplications, ICharityAp
proposals[proposalCount] = ApplicationsStorage.ApplicationProposal({
proposer: msg.sender,
application: _application,
meta: _meta,
meta: _metadata,
expiry: expiry,
executed: false
});

emit ApplicationProposed(proposalCount, msg.sender, _application.name, expiry, _meta);
emit ApplicationProposed(proposalCount, msg.sender, _application.name, expiry, _metadata);

if (isOwner[msg.sender]) {
confirmProposal(proposalCount);
Expand Down
2 changes: 1 addition & 1 deletion contracts/multisigs/CharityApplicationsStorage.sol
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ library ApplicationsStorage {
struct ApplicationProposal {
address proposer;
AccountMessages.CreateEndowmentRequest application;
bytes meta;
bytes metadata;
uint256 expiry;
bool executed;
}
Expand Down
2 changes: 1 addition & 1 deletion contracts/multisigs/interfaces/ICharityApplications.sol
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ abstract contract ICharityApplications {

function proposeApplication(
AccountMessages.CreateEndowmentRequest memory application,
bytes memory meta
bytes memory metadata
) public virtual;

function confirmProposal(uint256 proposalId) public virtual;
Expand Down

0 comments on commit 61e74e7

Please sign in to comment.