This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Add tests for AccountsDepositWithdrawEndowments facet #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNeshi
commented
Jul 18, 2023
| @@ -97,6 +99,7 @@ contract AccountsDepositWithdrawEndowments is | |||
| AccountStorage.State storage state = LibAccounts.diamondStorage(); | |||
| AccountStorage.Endowment storage tempEndowment = state.ENDOWMENTS[details.id]; | |||
|
|
|||
| // is it possible to have tokenAddress == address(0) | |||
| require(tokenAddress != address(0), "Invalid ERC20 token"); | |||
There was a problem hiding this comment.
It is never possible to have tokenAddress == address(0).
If we do not count the possibility that WMATIC address might not be set in the Registrar, then there are no test cases where this check could ever fail in this internal function.
0xNeshi
commented
Jul 18, 2023
contracts/core/accounts/facets/AccountsDepositWithdrawEndowments.sol
Outdated
Show resolved
Hide resolved
0xNeshi
commented
Jul 18, 2023
test/utils/helpers/types.ts
Outdated
| @@ -22,3 +22,17 @@ export enum VaultActionStatus { | |||
| FAIL_TOKENS_RETURNED, // Tokens returned to accounts contract | |||
| FAIL_TOKENS_FALLBACK, // Tokens failed to be returned to accounts contract | |||
| } | |||
|
|
|||
| export enum VaultType { | |||
There was a problem hiding this comment.
Suggestion: all of these types should probably be better placed in test/types.ts
There was a problem hiding this comment.
I have no preference :)
There was a problem hiding this comment.
Likewise, no real preference here.
There was a problem hiding this comment.
Will update in some of the future refactor PRs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152
Instructions on making this work
yarnoryarn installto install npm dependenciesyarn testto verify all tests still pass