Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Get some of the older tests up to date #208

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Jul 18, 2023

Wanted to remove contract-address.json updates from tests, so went ahead and did a quick cleanup.

Explanation of the solution

  • focused on tests I created (I understand those best, so was very fast)
  • remove use of actual deploy scripts
  • use smock instead of dummy contracts
  • general cleanup where appropriate

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn test to verify all tests still pass

@0xNeshi 0xNeshi added the enhancement New feature or request label Jul 18, 2023
@0xNeshi 0xNeshi self-assigned this Jul 18, 2023
@0xNeshi 0xNeshi changed the title Get older tests up to date Get some of the older tests up to date Jul 18, 2023
@stevieraykatz stevieraykatz merged commit 68fc289 into master Jul 18, 2023
1 check passed
@stevieraykatz stevieraykatz deleted the use-smock-in-old-tests branch July 18, 2023 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants