This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Registrar-related script fixes #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a fine way to do it I think. 👍 |
SovereignAndrey
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Add task for specifically deploying local infra * Deploy Router and Registrar to goerli, added goerli to contract-address json * Added new task for fee setting, fixed task for AP params * added infrastructure for managing strategy params * Added deployment task and deployed to Goerli * lint * Add network info updating task * Fixes to tasks * Made changes according to comments, still have some changes that are needed * Remove duped types from types, fix some small nits * lint * Use deployer address as placeholder until we have a ms on goerli * Remove unused import * Fixes and cleanup after merging master, new task for deploying all of Side Chain * Updates to dummy strategy, deployed new version * Fixes to tasks to use APTeamMS as owner of registrar, new task for updating network configs * Small fix to updateRegistrarNetworkConnections and other small changes to existing tasks * Registrar-related script fixes (#221) Good finds all around. * Add primary registrar upgrade task, upgrade registrar on mumbai * Remove debug logging * Fixed bad assumption in updateRegistrarNetworkConnections * Fixed issues in Router, adjusted tests accordingly (#229) --------- Co-authored-by: Nenad Misic <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s):
Explanation of the solution
networkName: "Polygon"as default for any network being deployed to (see Registrar.initialize) -> this was causing issues when updating its network connections with scripts that accepted partial updates (see how updateRegistrar helper function work).@stevieraykatz @SovereignAndrey I updated the initializer function to accept a
networkNameparameter as well, but it's possible I wasn't aware that"Polygon"was supposed to be the default network to set here. If so, let me know and I will revert this change.RegistrarMessages.InstantiateRequest.axelarGasRecv -> axelarGasService.Instructions on making this work
yarnoryarn installto install npm dependenciesyarn testto verify all tests still passmanage:registrar:setNetworkInfoscript on desired network