This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Fix activeOwnersCount
initialization in MultiSigGeneric
#222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s): #199
Explanation of the solution
Variable
activeOwnersCount
should be initialized in MultiSigGeneric.initialize otherwise it always remains 0 (zero), causing unintended behavior later on (e.g. when adding/removing owners -> if we try to remove an owner,activeOwnersCount
would be set to a negative value which is impossible with it being auint256
, causing a revert to happen).It was necessary to redeploy
CharityApplications
andAPTeamMultiSig
proxies as well because theirinitialize
methods had to be called again.Instructions on making this work
yarn
oryarn install
to install npm dependenciesyarn test
to verify all tests still passactiveOwnersCount
for any of the multisig contractsinitialize
function)