Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Acocunts Config Clean up + Missed Meta rename fix; #232

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

SovereignAndrey
Copy link
Contributor

@SovereignAndrey SovereignAndrey commented Jul 25, 2023

Closes #231

Explanation of the solution

  • Remove maxGeneralCategoryId & earlyLockedWithdrawFee from Accounts;
  • Use Registrar Fee lookup for Charity Early Withdraw Fee in Accounts;
  • Change one missed meta >> metadata;

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn test to verify all tests still pass

…se Registrar Fee lookup for Charity Easrly Withdraw Fee in Accounts; Change one missed meta>>metadata;
@SovereignAndrey SovereignAndrey added the bug Something isn't working label Jul 25, 2023
@SovereignAndrey SovereignAndrey self-assigned this Jul 25, 2023
@SovereignAndrey SovereignAndrey changed the title Acocunts Confirg Clean up + Missed Meta rename fix; Acocunts Config Clean up + Missed Meta rename fix; Jul 25, 2023
@0xNeshi 0xNeshi linked an issue Jul 25, 2023 that may be closed by this pull request
@0xNeshi 0xNeshi merged commit b609190 into master Jul 25, 2023
1 check passed
@0xNeshi 0xNeshi deleted the accts-ewfees-removed branch July 25, 2023 09:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move earlyLockedWithdrawFee from Accounts storage to Registrar
2 participants