Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Make DiamondInit > init dynamically set networkName and fix CharityApplications modifiers error messages #236

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Make DiamondInit > init dynamically set networkName and fix CharityApplications modifiers error messages #236

merged 4 commits into from
Jul 25, 2023

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Jul 25, 2023

Explanation of the solution

  • included update to DiamondInit > init to accept networkName and set it dynamically (currently set to "Polygon" by default)
  • fixed error messages in CharityApplications modifiers: proposalConfirmed & proposalNotConfirmed

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn test to verify all tests still pass

@0xNeshi 0xNeshi added the bug Something isn't working label Jul 25, 2023
@0xNeshi 0xNeshi self-assigned this Jul 25, 2023
@stevieraykatz stevieraykatz merged commit 7002e37 into master Jul 25, 2023
1 check passed
@stevieraykatz stevieraykatz deleted the minor-fixes branch July 25, 2023 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevieraykatz stevieraykatz stevieraykatz approved these changes

Assignees

@0xNeshi 0xNeshi

Labels
bug Something isn't working
Projects
No open projects
Angel Protocol dApp
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xNeshi @stevieraykatz