Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Donation match sender #241

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Donation match sender #241

merged 3 commits into from
Jul 27, 2023

Conversation

SovereignAndrey
Copy link
Contributor

@SovereignAndrey SovereignAndrey commented Jul 26, 2023

Closes: #22

Explanation of the solution

Variable created for holding the donation match, for use in Donation Matching flow. If passed in DepositRequest struct, under new donationMatch field, we use that address, otherwise we use the msg.sender for any messages that pass an address(0).

New AccountMessages.DepositRequest struct

struct DepositRequest {
    uint32 id;
    uint256 lockedPercentage;
    uint256 liquidPercentage;
    address donationMatch;
}

Instructions on making this work

  • run yarn or yarn install to install npm dependencies
  • run yarn test to verify all tests still pass

@SovereignAndrey SovereignAndrey added the bug Something isn't working label Jul 26, 2023
@SovereignAndrey SovereignAndrey self-assigned this Jul 26, 2023
@stevieraykatz stevieraykatz merged commit c47b6f8 into master Jul 27, 2023
1 check passed
@stevieraykatz stevieraykatz deleted the donationMatch-sender branch July 27, 2023 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Donation matching could fail due to use of tx.origin
2 participants