This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Remove redundant packages & update TypeScript to v5 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNeshi
commented
Jul 31, 2023
0xNeshi
commented
Jul 31, 2023
| @@ -27,7 +26,6 @@ | |||
| "@ethersproject/providers": "^5.6.6", | |||
| "@nomicfoundation/hardhat-chai-matchers": "^1.0.5", | |||
| "@nomicfoundation/hardhat-network-helpers": "^1.0.0", | |||
| "@nomicfoundation/hardhat-toolbox": "^2.0.2", | |||
There was a problem hiding this comment.
We already import all the packages "contained" within this package, so it is redundant
0xNeshi
commented
Jul 31, 2023
| "ts-node": "^10.9.1", | ||
| "tsconfig-paths": "^4.2.0", | ||
| "typechain": "^8.1.1", | ||
| "typescript": "^4.9.4" | ||
| }, | ||
| "dependencies": { | ||
| "@axelar-network/axelar-gmp-sdk-solidity": "^3.3.0", | ||
| "@axelar-network/axelar-local-dev": "^1.4.4", |
There was a problem hiding this comment.
Wasn't used anywhere
0xNeshi
commented
Jul 31, 2023
| @@ -58,27 +56,23 @@ | |||
| "prettier": "^2.8.8", | |||
| "prettier-plugin-solidity": "^1.1.3", | |||
| "solidity-coverage": "^0.8.3", | |||
| "ts-generator": "^0.1.1", | |||
There was a problem hiding this comment.
Wasn't used anywhere
0xNeshi
commented
Jul 31, 2023
| "@chainlink/contracts": "^0.6.1", | ||
| "@openzeppelin/contracts": "^4.8.3", | ||
| "@openzeppelin/contracts-upgradeable": "^4.8.3", | ||
| "@openzeppelin/hardhat-upgrades": "^1.23.1", | ||
| "@uniswap/v3-core": "github:AngelProtocolFinance/uniswap-v3-core#fullmath-fix", | ||
| "@uniswap/v3-periphery": "^1.4.3", | ||
| "dotenv": "^16.0.3", | ||
| "hardhat-interface-generator": "^0.0.6", |
There was a problem hiding this comment.
Wasn't used anywhere
0xNeshi
commented
Jul 31, 2023
| "keccak256": "^1.0.6", | ||
| "merkletreejs": "^0.3.9", | ||
| "mockdate": "^3.0.5", | ||
| "npm-check-updates": "^16.10.8", |
There was a problem hiding this comment.
Not sure about the benefits or why it was even added in the first place
stevieraykatz
approved these changes
Aug 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the solution
As the title says.
Reason to update to TS 5:
See more at https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#speed-memory-and-package-size-optimizations
Attempted to update to
ethers@6, but the following packages were causing problems as there seems to be no plans to update them to useethers@6:On an unrelated note, about the
@uniswap/v3-core > FullMath.solunary operator issue, someone created a PR to fix this, but the Uniswap team seems to not pay attention to community PRs atm 😕Uniswap/v3-core#659
Instructions on making this work
yarnoryarn installto install npm dependencies