Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Added GasManager facet and fixed an issue with GasFwd #250

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Added GasManager facet and fixed an issue with GasFwd #250

merged 8 commits into from
Aug 2, 2023

Conversation

stevieraykatz
Copy link
Contributor

@stevieraykatz stevieraykatz commented Aug 1, 2023 •
edited
Loading

Closes: #194

Explanation of the solution

  • Add a gas management facet responsible for wrapping the GasFwd contracts.
  • Sweep for closure will be used in the endowment closure flow
  • Sweep for endowment is used as a permissioned step to unlock funds in the gas fwd contract. It's permissioned to avoid gasFwd being used as an exploit vector
  • Add gas -- endowments can call this to take funds from the locked or liquid balances and transfer those funds to the gasFwd'er

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

@stevieraykatz stevieraykatz self-assigned this Aug 1, 2023
@stevieraykatz stevieraykatz changed the title Added GasManager facet and fixed an issue with GasFwd [WIP] Added GasManager facet and fixed an issue with GasFwd Aug 1, 2023
@stevieraykatz stevieraykatz changed the title [WIP] Added GasManager facet and fixed an issue with GasFwd Added GasManager facet and fixed an issue with GasFwd Aug 1, 2023
@stevieraykatz stevieraykatz removed the WIP label Aug 1, 2023
@SovereignAndrey SovereignAndrey merged commit 7af3568 into master Aug 2, 2023
1 check passed
@SovereignAndrey SovereignAndrey deleted the gas-fwd-facet branch August 2, 2023 09:02
@0xNeshi 0xNeshi mentioned this pull request Aug 2, 2023
Merged
stevieraykatz pushed a commit that referenced this pull request Aug 2, 2023
Refactors for PR #250 ("Added GasManager facet...") (#258)
f1e8159 
* Use Validator.canChange in AccountsGasManager

* Validate caller for correct vault type

* Update tests

* Update delegateIsValid to check envTime is strictly smaller than exp. date
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SovereignAndrey SovereignAndrey SovereignAndrey left review comments

Assignees

@stevieraykatz stevieraykatz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GasFwd user helpers/integration
2 participants
@stevieraykatz @SovereignAndrey