Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Fix failing CI - update all func params expecting SignerWithAddress to SignerWithAddress | Wallet #372

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

0xNeshi
Copy link
Contributor

@0xNeshi 0xNeshi commented Sep 8, 2023

Explanation of the solution

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

@0xNeshi 0xNeshi added the bug Something isn't working label Sep 8, 2023
@0xNeshi 0xNeshi self-assigned this Sep 8, 2023
@linear
Copy link

linear bot commented Sep 8, 2023

@0xNeshi 0xNeshi changed the title Fix failing CI Fix failing CI - update all func params expecting SignerWithAddress to SignerWithAddress | Wallet Sep 8, 2023
Copy link
Contributor

@SovereignAndrey SovereignAndrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good! Summarized in one line: | Wallet :)

@SovereignAndrey SovereignAndrey merged commit 52b4370 into AP-723-Mainnet-Deploy Sep 8, 2023
2 checks passed
@SovereignAndrey SovereignAndrey deleted the ap-723-fix branch September 8, 2023 11:29
SovereignAndrey pushed a commit that referenced this pull request Sep 8, 2023
* Deployed all contracts and verified to Mainnet

* Added Wallet as a valid output to getAPSigner

* Fix failing CI (#372)

---------

Co-authored-by: Nenad Misic <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants