Resolves AP-638, AP-784: Update `setStratParams` to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" #375

0xNeshi · 2023-09-12T10:30:39Z

Explanation of the solution

Instructions on making this work

run yarn or yarn install to install npm dependencies

…trategy's network (LocalRegistrar)

linear · 2023-09-12T10:30:41Z

AP-638 Implement shell script for updating cross-chain strat params

When a strat param is updated we need to:

start params in the registrar on the primary chain
and to update them on the cross chain where the strategy is implemented

config/index.ts

0xNeshi · 2023-09-12T10:46:41Z

plugins/index.ts

+      }
+  );
+
+  hre.changeNetwork = lazyFunction(


Changing Hardhat network during runtime is currently not possible, but is in the works. In the meantime, added this extension to our hardhat runtime that enables us to achieve this.

0xNeshi · 2023-09-12T10:47:21Z

plugins/index.ts

@@ -0,0 +1,56 @@
+/**
+ * @author misicnenad
+ * @description created based on unmaintained repo https://www.npmjs.com/package/hardhat-change-network


The linked repo is unmaintained and had some issues with our version of hardhat.
Just copy/pasted the code and fixed the issues

That's awesome man.

This "context switching" assumes that the hardhat accounts are the same for each network, yes? Might be good to make that explicit though I suppose our env config mostly enforces that anyway. This is irrelevant in cases where we're executing calls with a pkey

When we make this repo public, consider linking it in the issue! Some people might be interested in using this in the meantime :) Get those gh stars!

That's awesome man.

This "context switching" assumes that the hardhat accounts are the same for each network, yes? Might be good to make that explicit though I suppose our env config mostly enforces that anyway. This is irrelevant in cases where we're executing calls with a pkey

The function is reading Hardhat's config for the target network (the one being switched to), so any accounts configured on said network should be there.
What's really being changed here are just the provider (create one connecting to the target network) and the network metadata.

0xNeshi · 2023-09-12T10:49:27Z

types/enums.ts

@@ -1,3 +1,12 @@
+export enum ChainID {


Makes it easier to associate network name with chain ID + improves type-safety a bit

0xNeshi · 2023-09-12T10:52:18Z

tasks/types.ts

@@ -56,9 +59,72 @@ const stringArray: CLIArgumentType<Array<string>> = {
  },
 };

+function enums<T extends {[key in string]: string | number}>(


We can use this to validate types of other task params that should be cast to enums (see https://linear.app/angel-protocol/issue/AP-779/create-custom-task-argument-types-where-applicable)

linear · 2023-09-12T10:56:18Z

AP-784 Investigate how to estimate Tx gas data while respecting DRY principle

Context: #371 (comment)

An example where this is needed:

https://github.com/AngelProtocolFinance/evm-smart-contracts/blob/master/tasks/helpers/submitMultiSigTx.ts#L23

Possible resources:

Calculating estimated gas price for a given transaction: https://ethereum.stackexchange.com/a/124059
Info on getFeeData: https://docs.ethers.org/v5/api/providers/provider/#Provider-getFeeData
Parsing units into gwei: https://docs.ethers.org/v5/api/utils/display-logic/#utils-parseUnits

stevieraykatz

Left a couple comments but this looks so cool man. Great work extending hardhat!

stevieraykatz · 2023-09-12T18:39:41Z

plugins/index.ts

@@ -0,0 +1,56 @@
+/**
+ * @author misicnenad
+ * @description created based on unmaintained repo https://www.npmjs.com/package/hardhat-change-network


That's awesome man.

This "context switching" assumes that the hardhat accounts are the same for each network, yes? Might be good to make that explicit though I suppose our env config mostly enforces that anyway. This is irrelevant in cases where we're executing calls with a pkey

stevieraykatz · 2023-09-12T18:42:46Z

types/enums.ts

@@ -1,3 +1,12 @@
+export enum ChainID {


0xNeshi added 10 commits September 12, 2023 09:36

Add missing .network log

c595bab

Remove redundant dotenv.config call

f3ca2cb

Add 'changeNetwork' plugin

1ab837a

Add enum ChainID

d6d1c27

Add 'enums' CLI type for hardhat tasks

4ae71ea

Update 'setStratParams' to run both on Polygon (main Registrar) and s…

c3895c0

…trategy's network (LocalRegistrar)

Add comments to plugin

379d849

Remove redundant comments from type-extensions

22cac89

Fix cliTypes.enums to better check string enum values

8e5b08b

Update rest of code to use ChainID enum

f8b638f

0xNeshi added the enhancement New feature or request label Sep 12, 2023

0xNeshi self-assigned this Sep 12, 2023

0xNeshi commented Sep 12, 2023

View reviewed changes

config/index.ts Show resolved Hide resolved

0xNeshi commented Sep 12, 2023

View reviewed changes

0xNeshi added 2 commits September 12, 2023 12:48

Make modifyExisting a flag

f874f35

Set gas price in submitMultiSigTx by reading current fee data

f0579c8

0xNeshi commented Sep 12, 2023

View reviewed changes

0xNeshi changed the title ~~Ap 638: Update setStratParams to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)"~~ Ap 638, Ap 784: Update setStratParams to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" Sep 12, 2023

0xNeshi changed the title ~~Ap 638, Ap 784: Update setStratParams to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)"~~ Resolves Ap 638, Ap 784: Update setStratParams to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" Sep 12, 2023

stevieraykatz approved these changes Sep 12, 2023

View reviewed changes

SovereignAndrey merged commit 8936571 into master Sep 13, 2023

SovereignAndrey deleted the ap-638 branch September 13, 2023 04:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolves AP-638, AP-784: Update `setStratParams` to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" #375

Resolves AP-638, AP-784: Update `setStratParams` to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" #375

0xNeshi commented Sep 12, 2023

linear bot commented Sep 12, 2023

0xNeshi Sep 12, 2023

0xNeshi Sep 12, 2023

stevieraykatz Sep 12, 2023

stevieraykatz Sep 12, 2023

0xNeshi Sep 13, 2023

0xNeshi Sep 12, 2023 •

edited

Loading

stevieraykatz Sep 12, 2023

0xNeshi Sep 12, 2023

linear bot commented Sep 12, 2023

stevieraykatz left a comment

stevieraykatz Sep 12, 2023

stevieraykatz Sep 12, 2023

Resolves AP-638, AP-784: Update setStratParams to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" #375

Resolves AP-638, AP-784: Update setStratParams to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" #375

Conversation

0xNeshi commented Sep 12, 2023

Explanation of the solution

Instructions on making this work

linear bot commented Sep 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xNeshi Sep 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linear bot commented Sep 12, 2023

stevieraykatz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Resolves AP-638, AP-784: Update `setStratParams` to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" #375

Resolves AP-638, AP-784: Update `setStratParams` to run both on Polygon (main Registrar) and strategy's network (LocalRegistrar)" #375

0xNeshi Sep 12, 2023 •

edited

Loading