Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

Fixes to dummy deployment to include emitter #387

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

stevieraykatz
Copy link
Contributor

Explanation of the solution

  • There were a few issues with the dummy strategy on testnet mostly related to registrar configs. They aren't tracked here, but there were reflected on-chain as config changes and we can now successfully deposit.
  • The dummy strategy contract has been updated to be less opaque and returns 1:1
  • The dummy strategy task now adds the vaults to the emitter so that they can emit events

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

@stevieraykatz
Copy link
Contributor Author

I learned a lot of good stuff getting this dummy set up. Specifically, when establishing a side chain, we need:

  • setAccountsContract
  • setTokenAccepted
  • setNetworkParams
  • setRouterAsOperator

And we also need to verify vaults and strategies upon deployment. All of this will be reflected in a larger PR: #384

@stevieraykatz stevieraykatz self-assigned this Sep 21, 2023
@SovereignAndrey SovereignAndrey merged commit 3ef06b9 into master Sep 22, 2023
1 check passed
@SovereignAndrey SovereignAndrey deleted the dummy-strategy-fixes branch September 22, 2023 05:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants