Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

AP-786 Strategy Cleanup #397

Merged
merged 4 commits into from
Oct 3, 2023
Merged

AP-786 Strategy Cleanup #397

merged 4 commits into from
Oct 3, 2023

Conversation

stevieraykatz
Copy link
Contributor

Explanation of the solution

This PR encapsulates two changes that are blocking for strategy development and flux deployment:

Refactor
I found that the Flux implementation was duplicating a lot of generic strategy-specific logic and genercized it further and moved it into APStrategy_V1. This part of the PR should be a no-op change, just a refactor.

Flux Strategy -> SafeERC20
I also changed the Flux strategy to using SafeERC20 instead of in-line approve/transfer checks. This should help with readability and gas. Additionally, I was using the Flux interface for interfacing with USDC. Though technically valid, that wasn't a good choice for readability... I'm not really sure why I made it in the first place. I've switched to using our standard IERC20 with SafeERC20 in its stead.

Instructions on making this work

  • run yarn or yarn install to install npm dependencies

@linear
Copy link

linear bot commented Oct 2, 2023

AP-786 Deploy Flux Strategy

This involves a number of steps:

  • Deploy a testnet strategy/vault pair
  • Run deploySideChain on Ethereum mainnet
  • Deploy the Flux strategy contracts
  • Configure the registrars (see AP-638)

@stevieraykatz stevieraykatz self-assigned this Oct 2, 2023
@SovereignAndrey SovereignAndrey merged commit 1470961 into master Oct 3, 2023
1 check passed
@SovereignAndrey SovereignAndrey deleted the ap-786-strategy-cleanup branch October 3, 2023 02:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants