✨🏢 Improve I-CAD storage and search #599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrelet
requested changes
Feb 4, 2025
| @@ -119,7 +119,7 @@ export async function action({ request, params }: ActionFunctionArgs) { | |||
| colorId: formData.data.colorId || null, | |||
| description: formData.data.description || null, | |||
| gender: formData.data.gender, | |||
| iCadNumber: formData.data.iCadNumber || null, | |||
| iCadNumber: formData.data.iCadNumber.replace(/\s+/g, "") || null, | |||
There was a problem hiding this comment.
C'est la bonne manière de retirer les espaces 👌.
Comme tu peux voir, tu as dû faire le changement dans les deux fichiers (edit et new). Cette transformation peut être écrite une seule fois si elle est déplacée dans l'objet ActionFormData du fichier apps/admin/src/animals/profile/form.tsx.
ActionFormData est utilisé pour valider et transformer les données issues du formulaire de profil d'un animal (AnimalProfileForm, dans le même fichier, utilisé pour la création et édition).
En t'inspirant des transformations déjà présentes (isOkCats et isOkChildren), ta mission si tu l’acceptes (🤣), est de déplacer les .replace() dans une transformation sur iCadNumber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.