Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
models: adjust MoreThanFNodesCommitted check
Based on the neo-project/neo-modules#792 (comment) the definition of MoreThanFNodesCommitted should be adjusted to match the core algorithm as it's the key factor of four-nodes deadlock scenario. There are two changes: 1. We consider the node to be "Committed" if it has the Commit message sent at _any_ view. 2. We should count lost nodes as far. We consider the node to be "Lost" if it hasn't sent any messages in the current round. Based on this adjustment, the first liveness lock scenario mentioned in neo-project/neo-modules#792 (comment) ("Liveness lock with four non-faulty nodes") is unreachable. However, there's stil a liveness lock when one of the nodes is in the RMDead list, i.e. can "die" at any moment. Consider running the base model specification with the following configuration: ``` RM RMFault RMDead MaxView {0, 1, 2, 3} {} {0} 2 ```
- Loading branch information