Fix a bug where hover-text isn't shown for indoor pots when they are placed on flooring #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…placed on flooring
NermNermNerm
commented
Dec 13, 2024
| @@ -111,20 +111,17 @@ private void OnUpdateTicked(object? sender, UpdateTickedEventArgs e) | |||
| _currentTerrain.Value = terrain; | |||
| } | |||
|
|
|||
| // Make sure that _terrain is null before overwriting it because Tea Saplings are added to terrainFeatures and not IndoorPot.bush | |||
| if (_currentTerrain.Value != null || _currentTile.Value is not IndoorPot pot) | |||
There was a problem hiding this comment.
The real essence of the change is to remove "_currentTerrain.Value != null ||". (everything else is just syntax).
As best I can tell, TeaBushes used to work very differently from everything else back in the day. But now things are a whole lot simpler. I've been able to test this in several saves with tea bushes but don't have one handy where the tea bushes are supposed to be harvestable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To repro the bug:
Note that it doesn't show anything.