Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace babel-eslint with @babel/eslint-parser #267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

henhal
Copy link

@henhal henhal commented Oct 20, 2021

As per output during install:

warning serverless-bundle > [email protected]: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.

@jayair jayair added the internal An internal tooling related change label Oct 20, 2021
@jayair
Copy link
Member

jayair commented Oct 20, 2021

Hmm not sure what's causing the tests to fail here.

@samatcd
Copy link

samatcd commented Nov 25, 2021

@jayair my guess is that "parser": "babel-eslint" config in serverless-bundle/src/eslintrc.json needs to change to @babel/eslint-parser.

@jayair
Copy link
Member

jayair commented Nov 25, 2021

Oh I see. Anybody want to take this on and fix the tests so we can merge it?

@Ionut-Milas
Copy link

Any update on this ?

@jayair
Copy link
Member

jayair commented Jan 17, 2022

If somebody could figure out what's going on with the tests, then I can merge this and publish it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal tooling related change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants