-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12 and update version to 1.4.4 #131
base: master
Are you sure you want to change the base?
Conversation
Changed Files
|
Reviewer's Guide by SourceryThis pull request adds support for Python 3.12 and updates the package version to 1.4.4. It also adjusts the minimum Python dependency version to 3.8.1 to accommodate broader compatibility. Class diagram showing version compatibility changesclassDiagram
class TanabeSugano {
version: 1.4.4
}
class PythonDependencies {
python: >=3.8.1,<4.0
pandas: >=1.2.4,<4.0.0
}
class NumPyVersions {
Python3_8: ^1.24.4
Python3_9: ^1.26.4
Python3_10_to_3_12: ^2.0.2
}
TanabeSugano --> PythonDependencies
PythonDependencies --> NumPyVersions
note for TanabeSugano "Updated from 1.4.3"
note for PythonDependencies "Now supports Python 3.12"
note for NumPyVersions "Version requirements per Python version"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- The PR lowers the minimum Python version from 3.9 to 3.8.1 while adding Python 3.12 support. Could you explain the rationale for expanding backwards compatibility in what appears to be a forward-compatibility update? This could introduce risks if the codebase wasn't previously tested with Python 3.8.1.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Introduce support for Python 3.12 in the classifiers and update the version to 1.4.4 while adjusting the Python dependency range.
Summary by Sourcery
New Features: