Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 and update version to 1.4.4 #131

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Anselmoo
Copy link
Owner

@Anselmoo Anselmoo commented Jan 11, 2025

Introduce support for Python 3.12 in the classifiers and update the version to 1.4.4 while adjusting the Python dependency range.

Summary by Sourcery

New Features:

  • Added support for Python 3.12.

Copy link

semanticdiff-com bot commented Jan 11, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  tanabesugano/test/test_matrices.py  100% smaller
  tanabesugano/matrices.py  25% smaller
  .github/workflows/python-package.yml Unsupported file format
  poetry.lock Unsupported file format
  pyproject.toml Unsupported file format
  tanabesugano/__init__.py  0% smaller
  tanabesugano/test/test_num.py  0% smaller
  uv.lock Unsupported file format

Copy link

sourcery-ai bot commented Jan 11, 2025

Reviewer's Guide by Sourcery

This pull request adds support for Python 3.12 and updates the package version to 1.4.4. It also adjusts the minimum Python dependency version to 3.8.1 to accommodate broader compatibility.

Class diagram showing version compatibility changes

classDiagram
    class TanabeSugano {
        version: 1.4.4
    }
    class PythonDependencies {
        python: >=3.8.1,<4.0
        pandas: >=1.2.4,<4.0.0
    }
    class NumPyVersions {
        Python3_8: ^1.24.4
        Python3_9: ^1.26.4
        Python3_10_to_3_12: ^2.0.2
    }
    TanabeSugano --> PythonDependencies
    PythonDependencies --> NumPyVersions
    note for TanabeSugano "Updated from 1.4.3"
    note for PythonDependencies "Now supports Python 3.12"
    note for NumPyVersions "Version requirements per Python version"
Loading

File-Level Changes

Change Details Files
Added Python 3.12 support in classifiers.
  • Added Python 3.12 to the list of supported Python versions in the classifiers section.
pyproject.toml
Updated package version.
  • Updated version from 1.4.3 to 1.4.4.
pyproject.toml
Adjusted Python dependency range.
  • Modified the Python dependency range from ">=3.9,<4.0" to ">=3.8.1,<4.0".
  • Updated the numpy dependency version for Python 3.8 from ">=3.8,<3.9" to ">=3.8.1,<3.9".
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Anselmoo - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The PR lowers the minimum Python version from 3.9 to 3.8.1 while adding Python 3.12 support. Could you explain the rationale for expanding backwards compatibility in what appears to be a forward-compatibility update? This could introduce risks if the codebase wasn't previously tested with Python 3.8.1.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant