-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: ⬆️ update configuration files for improved linting and formattingUpdate linting and formatting configurations #1749
Conversation
…guration Pre Commit mirrors prettier is archived
Changed Files
|
Reviewer's Guide by SourceryThis PR updates configuration files for improved linting and formatting. It updates ruff version, disables linters (black, isort) via .trunk/trunk.yaml, and adds actionlint. Deprecated prettier configuration is removed from .pre-commit-config.yaml. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please update the contributing guidelines to reflect the new development tooling setup, particularly the changes around code formatting.
- Could you explain the rationale for disabling black/isort and removing prettier? This would help reviewers understand the direction for code formatting.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 4520 4535 +15
=========================================
+ Hits 4520 4535 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Quality Gate passedIssues Measures |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Update project configuration files for linting and formatting, including upgrading Ruff, removing Prettier, and adding Actionlint.
Build: