feat: ⭐ Introducing UV as package manager
#1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files |
Reviewer's Guide by SourceryThis pull request migrates the project from Poetry to Hatch for build management. It also updates the project metadata, dependencies, and development tooling configurations. Class diagram showing project metadata changesclassDiagram
class ProjectMetadata {
+name: SpectraFit
+version: str
+description: str
+authors: List
+dependencies: List
+optional_dependencies: Dict
}
class BeforePoetry {
+version: 1.1.0
+tool.poetry: Dict
+tool.poetry.dependencies: Dict
+tool.poetry.group.dev.dependencies: Dict
+tool.poetry.group.docs.dependencies: Dict
}
class AfterHatch {
+version: 1.2.0
+project: Dict
+project.dependencies: List
+dependency-groups.dev: List
+dependency-groups.docs: List
+tool.hatch: Dict
}
ProjectMetadata <|-- BeforePoetry
ProjectMetadata <|-- AfterHatch
note for BeforePoetry "Poetry configuration"
note for AfterHatch "Hatch configuration"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
bot
added
testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1785 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 4535 4535
=========================================
Hits 4535 4535
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…it with verbose output
for more information, see https://pre-commit.ci
…wheel installation
…install uv for environment setup
github-actions
bot
added
the
codespaces
…itHub CLI and remove unused features
…and Git features, and adjust GitHub CLI installation
… the package manager for SpectraFit
…dependency management
…pendency management
github-actions
bot
added
the
documentation
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding documentation about the rationale for migrating from Poetry to UV in the PR description or changelog, to help users understand the benefits and motivation behind this tooling change.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -262,11 +296,11 @@ available plugins are: | |||
| [2]: https://conda.io/docs/ | |||
| [3]: https://anaconda.org/conda-forge/spectrafit | |||
| [4]: https://github.com/Anselmoo/spectrafit/pkgs/container/spectrafit | |||
| [5]: | |||
| https://github.com/jupyter/docker-stacks/blob/main/scipy-notebook/Dockerfile | |||
| [5]: https://github.com/jupyter/docker-stacks/blob/main/scipy-notebook/Dockerfile | |||
| [6]: ../../plugins/jupyter-spectrafit-interface | |||
| [7]: https://github.com/conda-forge/spectrafit-feedstock | |||
| [8]: https://python-poetry.org/docs/ | |||
| [9]: https://github.com/Anselmoo/spectrafit/ | |||
| [10]: https://www.sigstore.dev | |||
There was a problem hiding this comment.
issue: Incorrect link for UV.
This link points to sigstore.dev. It should point to the UV documentation.
| ``` | ||
| _Usage_: | ||
|
|
||
| ```bash | ||
| poetry run spectrafit --help | ||
| uv run spectrafit --help |
There was a problem hiding this comment.
suggestion: Potential issue with uv run command.
uv run might not execute within the project's virtual environment. Consider using uv exec spectrafit --help instead.
Suggested change
| uv run spectrafit --help | |
| uv exec spectrafit --help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Update project dependencies and migrate from Poetry to UV.
Enhancements:
Build:
CI:
Tests: