Fix: Remove unexpected argument from APIRankers

[srisudarsan]

With latest change (ce422c3) of moving from Pydantic to a constructor based class, unexpected parameter present in APIRankers makes the initialisation fail.
Removing the unexpected variable text from being passed

[srisudarsan]

@bclavie Can you please review this ?

[bclavie]

Thank you for your contribution!

Could you provide the exact issue? This fix cannot be merged as-is as we do not want to remove the text from Result objects.

[srisudarsan]

Sure. Prior to this commit, we had Result as a Pydantic Model and passing an non-existing field to a Pydantic Model does not raise an exception, whereas now, we have rewritten Result with a classic Python style constructor without the text as a class variable to the init method, thus when we try to initialise a Result object with text field which is not defined in the init it throws an error as follows

Traceback (most recent call last):
  File "rerankers/main.py", line 3, in <module>
    results = ranker.rank(query="I love you", docs=["I hate you", "I really like you"], doc_ids=[0, 1])
  File "rerankers/rerankers/models/api_rankers.py", line 112, in rank
    results = self._parse_response(response.json(), docs)
  File "rerankers/rerankers/models/api_rankers.py", line 92, in _parse_response
    Result(
TypeError: __init__() got an unexpected keyword argument 'text'

CMIIW, Result object has a field called document which has text in it , thus making the text field in the Result object redundant

[srisudarsan]

Hello @bclavie , did you manage to check this out ?