Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix warnings #929

Closed
wants to merge 1 commit into from
Closed

fix warnings #929

wants to merge 1 commit into from

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Sep 12, 2024

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

flomnes
flomnes reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you need = "" for std::strings and = {} for std::vectors

@a-zakir
Copy link
Contributor Author

a-zakir commented Sep 12, 2024

Not sure you need = "" for std::strings and = {} for std::vectors

they are maybe unnecessary, it doesn't cost anything to do so though

@a-zakir a-zakir closed this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-zakir @flomnes