Dockerfile to work on centos7 locally #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pet-mit
requested changes
Jan 2, 2025
docker/centos-local-build/run.sh
Outdated
Comment on lines
3
to
4
| --mount type=bind,src=/home/marechaljas/CLionProjects/antares-xpansion,dst=/mnt/sources \ | ||
| --mount type=bind,src=/home/marechaljas/CLionProjects/docker_caches,dst=/mnt/caches \ |
There was a problem hiding this comment.
you put your folder names here, was it intentional as an example? in that case, maybe add a mention in the readme
There was a problem hiding this comment.
Thank you, I've updated to now accept parameters
pet-mit
requested changes
Jan 3, 2025
pet-mit
reviewed
Jan 9, 2025
| tar -czf antares-xpansion-centos.tar.gz -C $install_dir . --exclude='examples' | ||
| chmod 777 antares-xpansion-centos.tar.gz |
There was a problem hiding this comment.
also remove all other files?
There was a problem hiding this comment.
which "all other files" ?
There was a problem hiding this comment.
on my PC the build folder ends up like this :
if I understand well, only the archive is needed. you can delete the 4 dirs ?
There was a problem hiding this comment.
No. The point of having them in this directory instead of the container is to be able to reuse them in subsequent build. Especially the vcpkg cache.
pet-mit
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new setup for building
xpansionin a CentOS 7 environment using Docker. The changes include a README file with detailed instructions, a build script, a Dockerfile, and a run script.The most important changes include:
Documentation:
docker/centos-local-build/README.MD: Added a comprehensive guide on how to locally generate a CentOS 7 asset, including prerequisites, usage instructions, and advanced usage scenarios.Build Script:
docker/centos-local-build/build.sh: Introduced a script to build and generate the asset, including setting up directories, downloading dependencies, and configuring the build environment.Docker Configuration:
docker/centos-local-build/dockerfile: Added a Dockerfile to create an image with the necessary environment for buildingxpansion.Run Script:
docker/centos-local-build/run.sh: Added a script to streamline the process of building and running the Docker container.