Better handling on solver names #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper to handle solver_names casse
tbittar
reviewed
Jan 15, 2025
...m_modifier/include/antares-xpansion/lpnamer/problem_modifier/MPSFileProblemProviderAdapter.h
Outdated
Show resolved
Hide resolved
src/cpp/lpnamer/problem_modifier/MPSFileProblemProviderAdapter.cpp
Outdated
Show resolved
Hide resolved
tbittar
reviewed
Jan 15, 2025
tbittar
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce "SolverConfig" as a helper class to encapsulate a solver name. SolverConfig is used to perform check and operations on solver names and encapsulated string logic like upper/lower casing, solver name equality and so on
Solver Factory Enhancements:
Introduced
SolverConfigclass to encapsulate solver configuration details and support case-insensitive solver name comparisons. (src/cpp/multisolver_interface/SolverConfig.cpp,src/cpp/multisolver_interface/CMakeLists.txt) [1] [2]Refactored
SolverFactorymethods to acceptSolverConfigobjects, improving the clarity and robustness of solver creation logic. (src/cpp/multisolver_interface/SolverFactory.cpp) [1] [2] [3]By introducing the
SolverConfigclass and updating the relevant components to use this new class, the codebase is now more maintainable and less error-prone, with improved handling of solver configurations.