Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IF: CDT support for IF host function #210

Closed
Tracked by #245
arhag opened this issue Aug 18, 2023 · 1 comment · Fixed by #218
Closed
Tracked by #245

IF: CDT support for IF host function #210

arhag opened this issue Aug 18, 2023 · 1 comment · Fixed by #218
Assignees
Milestone

Comments

@arhag
Copy link
Member

arhag commented Aug 18, 2023

Depends on AntelopeIO/leap#1511.

Add C++ wrapper for the new set_finalizers host function introduced with the IF protocol feature. Ensure this is added into a header file in a way that prevents a contract compiling with the new version of CDT but that does not actually use the new wrapper function from accidentally including set_finalizers as a dependency in the compiled WASM file.

Should be done at same time as AntelopeIO/reference-contracts#26 (Finalizer Action for Bios Contract)

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 18, 2023
@arhag arhag added 👍 lgtm and removed triage labels Aug 18, 2023
@arhag arhag added this to the CDT 4.1.0-rc1 milestone Aug 18, 2023
@arhag arhag changed the title IF: CDT support for BLS public key encoding and for IF host function IF: CDT support for IF host function Aug 24, 2023
@dimas1185 dimas1185 moved this from Todo to In Progress in Team Backlog Aug 31, 2023
@heifner
Copy link
Member

heifner commented Aug 31, 2023

set_finalizer host function available in leap branch hotstuff_integration

The struct used for set_finalizers is:
AntelopeIO/leap#1588

   struct abi_finalizer_authority {
      std::string              description;
      uint64_t                 fweight = 0; // weight that this finalizer's vote has for meeting fthreshold
      std::array<uint8_t, 144> public_key_g1_jacobian; // Jacobian little endian
   };
   struct abi_finalizer_set {
      uint64_t                             fthreshold = 0;
      std::vector<abi_finalizer_authority> finalizers;
   };

@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Sep 6, 2023
@arhag arhag linked a pull request Sep 7, 2023 that will close this issue
2 tasks
@BenjaminGormanPMP BenjaminGormanPMP moved this from Awaiting Review to Todo in Team Backlog Nov 7, 2023
@linh2931 linh2931 self-assigned this Dec 6, 2023
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Dec 6, 2023
@linh2931 linh2931 moved this from In Progress to Awaiting Review in Team Backlog Dec 9, 2023
@arhag arhag closed this as completed Dec 11, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Dec 11, 2023
@arhag arhag modified the milestones: Unknown, CDT 5.0, IF Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants