Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: add set_finalizers host function #218

Merged
merged 20 commits into from
Dec 11, 2023
Merged

IF: add set_finalizers host function #218

merged 20 commits into from
Dec 11, 2023

Conversation

dimas1185
Copy link
Contributor

resolves #210

Change Description

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

dimas1185 and others added 5 commits September 6, 2023 16:47
@dimas1185
added set_finalizers host function
01d06ab
@dimas1185
leap main -> hotstuff_integration
6f61e69
@oschwaldp-oci @dimas1185
Make leap-dev download target configurable.
5a06647 
Use defaults.json to specify default location/target to attempt to downlaod the leap-dev package from. Allow dynamic configuration through workflow_dispatch input in github.
@oschwaldp-oci @dimas1185
Remove unneeded token with v3.
492d923
@dimas1185
Merge branch 'hotstuff_integration' into set_finalizers_hf
5f1ad6f
@dimas1185 dimas1185 changed the title added set_finalizers host function add set_finalizers host function Sep 6, 2023
@arhag arhag linked an issue Sep 7, 2023 that may be closed by this pull request
IF: CDT support for IF host function #210
Closed
heifner
heifner requested changes Sep 7, 2023
View reviewed changes
libraries/eosiolib/capi/eosio/privileged.h Outdated Show resolved Hide resolved
libraries/eosiolib/capi/eosio/privileged.h Outdated Show resolved Hide resolved
libraries/eosiolib/contracts/eosio/finalizer_set.hpp Outdated Show resolved Hide resolved
libraries/eosiolib/contracts/eosio/finalizer_set.hpp Outdated Show resolved Hide resolved
libraries/native/intrinsics.cpp Outdated Show resolved Hide resolved
tests/integration/set_finalizers_tests.cpp Outdated Show resolved Hide resolved
@linh2931 linh2931 requested review from arhag and heifner December 7, 2023 16:26
heifner
heifner requested changes Dec 7, 2023
View reviewed changes
tests/integration/set_finalizers_tests.cpp Outdated Show resolved Hide resolved
libraries/eosiolib/capi/eosio/privileged.h Outdated Show resolved Hide resolved
libraries/eosiolib/contracts/eosio/finalizer_set.hpp Outdated Show resolved Hide resolved
tests/integration/set_finalizers_tests.cpp Outdated Show resolved Hide resolved
@linh2931
Fix set_finalizers_tests
5e504d3 
* Use BOOST_REQUIRE_EQUAL and BOOST_REQUIRE; existing BOOST_ASSERT does
  not run during tests
* Update to Leap changes of proposed_finalizer_set to  proposed_finalizer_policy
@linh2931
Update set_finalizers_tests
cb73eae 
* Fixed breaking strict-aliasing rules
* Added public key check
@linh2931
rename finalizer_set.hpp -> finalizer_policy.hpp
30786fa
@linh2931
update set_finalizers_tests.cpp to include finalizer_policy.hpp
8ab3b6b
@linh2931 linh2931 requested review from heifner and greg7mdp December 9, 2023 02:57
@heifner heifner changed the title add set_finalizers host function IF: add set_finalizers host function Dec 9, 2023
heifner
heifner requested changes Dec 9, 2023
View reviewed changes
libraries/eosiolib/capi/eosio/instant_finality.h Outdated Show resolved Hide resolved
libraries/eosiolib/capi/eosio/instant_finality.h Outdated Show resolved Hide resolved
@linh2931 linh2931 requested a review from heifner December 10, 2023 14:37
@linh2931 linh2931 merged commit 4c47d24 into hotstuff_integration Dec 11, 2023
6 checks passed
@linh2931 linh2931 deleted the set_finalizers_hf branch December 11, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 left review comments

@greg7mdp greg7mdp greg7mdp approved these changes

@heifner heifner heifner approved these changes

@arhag arhag Awaiting requested review from arhag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IF: CDT support for IF host function
5 participants
@dimas1185 @greg7mdp @heifner @linh2931 @oschwaldp-oci