-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IF: set_finalizers updates #1598
Merged
heifner
merged 16 commits into
hotstuff_integration
from
GH-1523-finalizer-set-transition-2
Sep 7, 2023
Merged
IF: set_finalizers updates #1598
heifner
merged 16 commits into
hotstuff_integration
from
GH-1523-finalizer-set-transition-2
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block_header extension.
…om/AntelopeIO/leap into GH-1523-finalizer-set-transition-2
…-finalizer-set-transition-2
greg7mdp
approved these changes
Sep 6, 2023
linh2931
reviewed
Sep 6, 2023
linh2931
reviewed
Sep 6, 2023
…-finalizer-set-transition-2
linh2931
approved these changes
Sep 7, 2023
greg7mdp
approved these changes
Sep 7, 2023
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalizer_set
toblock_header
extensionlast_proposed_finalizer_set_generation
toblock_header_state
set_finalzers
host function toeos-vm-oc/intrinsic_mapping
bls_public_key
set_finalizers
unittest.Note: snapshot tests are failing because of
block_header_state
addition oflast_proposed_finalizer_set_generation
. I think the snapshot test should be fixed as part of #1558. I've commented it out and added a warning for now.