Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jquery): update to 3.7.1 #297

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Dec 19, 2023

@keunes
Copy link
Member

keunes commented Dec 24, 2023

Thanks. I'm on my work laptop and don't remember from the top of my head: do you know where/what for we use jquery? Just to make sure it's all working as expected still.
(If not, I'll have a look some point next week, after Christmas.)

@ByteHamster
Copy link
Member

Why do we need to upgrade it anyway? In my experience, unless there is an actual reason to upgrade dependencies, upgrading them just makes a headache

@keunes
Copy link
Member

keunes commented Dec 24, 2023

dependencies, upgrading them just makes a headache

I can understand for mobile apps where there's a lot of different contexts, where you can't test them all yourself.

But for my laptop, having to jump major software versions & their dependencies actually gives a headache. Oftentimes I find myself starting from scratch because it's easier.

Same for web development I think: we can actually test all major cases ourselves; the list of variables is much smaller.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Dec 26, 2023

jQuery is used by Bootstrap 4.

@keunes keunes merged commit 31bfa12 into AntennaPod:master Jan 7, 2024
4 checks passed
@Rotzbua Rotzbua deleted the chore_jquery branch January 7, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants