Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MRT and clean-up cubemap FBOs #182

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

GlennFolker
Copy link
Contributor

  • Made CubemapSide.all = values().
  • Completely remove FrameBufferCubemap's nextSide() as it completely chokes when another FBO is bound while it is already bound, causing currentSide to go back to -1 when it is rebound, resulting in an eternal while-loop.
  • Refactored:
    • disposeColorTexture() ->disposeTexture()
    • attachFrameBufferColorTexture() -> attachTexture() with an attachment parameter, e.g. Gl.colorAttachment0 and Gl.depthAttachment

@Anuken Anuken merged commit 124ba82 into Anuken:master Dec 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants