Fix/invalid member (#114)

* Fix: AuctionService nickname 검사없이 NULL가져오던거 수정 * Fix: AuctionService nickname 검사없이 NULL가져오던거 수정
AnywayClear · Aug 15, 2023 · 7d0004a · 7d0004a
1 parent 1f68eb5
commit 7d0004a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/main/java/com/anywayclear/exception/GlobalExceptionHandler.java b/src/main/java/com/anywayclear/exception/GlobalExceptionHandler.java
@@ -6,8 +6,6 @@
 import org.springframework.web.bind.annotation.RestControllerAdvice;
 import org.springframework.web.servlet.NoHandlerFoundException;
 
-import javax.validation.ConstraintViolationException;
-
 import java.sql.SQLIntegrityConstraintViolationException;
 
 import static com.anywayclear.exception.ExceptionCode.*;

diff --git a/src/main/java/com/anywayclear/service/AuctionService.java b/src/main/java/com/anywayclear/service/AuctionService.java
@@ -56,20 +56,22 @@ public BiddingResponse Bidding(long auctionId, String consumerId, BiddingRequest
     @Transactional
     public void checkAuctionFinished(long auctionId) {
         Auction auction = auctionRepository.findById(auctionId).orElseThrow(() -> new CustomException(INVALID_AUCTION_ID));
-        Member consumer = memberRepository.findByNickname(auction.getNickname()).orElseThrow(()->new CustomException(INVALID_MEMBER));
         Produce produce = auction.getProduce();
         if (produce.getStatus() == 1 && !auction.isClosed() && LocalDateTime.now().isAfter(auction.getLastBidding().plusMinutes(4))) {
             auction.setClosed(true);
             produce.setEndDate(auction.getUpdatedAt());
 //            produce.setEa(produce.getEa() - 1);
-            DealCreateRequest dealCreateRequest = DealCreateRequest.builder()
-                    .endPrice(auction.getPrice())
-                    .produce(produce)
-                    .seller(produce.getSeller())
-                    .consumer(consumer)
-                    .build();
-            dealService.createDeal(dealCreateRequest);
-                    produce.setStatus(2);
+            if(!produce.getStartDate().equals(auction.getLastBidding())) {
+                Member consumer = memberRepository.findByNickname(auction.getNickname()).orElseThrow(() -> new CustomException(INVALID_MEMBER));
+                DealCreateRequest dealCreateRequest = DealCreateRequest.builder()
+                        .endPrice(auction.getPrice())
+                        .produce(produce)
+                        .seller(produce.getSeller())
+                        .consumer(consumer)
+                        .build();
+                dealService.createDeal(dealCreateRequest);
+            }
+            produce.setStatus(2);
             for (Auction a : produce.getAuctionList()) {
                 if (!a.isClosed()) {
                     produce.setStatus(1);