feat: better CLI message when compiling a dependency produces no contracts #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Jun 12, 2024
antazoey
force-pushed
the
feat/better-error-missing-compiler
branch
from
f964f9c to
9c5e963
Compare
dtdang
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
was confused for a bit because i had uninstalled
ape-soliditybutape pm compile . --forcewas not telling me it was successful but it nothing was really happening...How I did it
detect if no result and warn.
additionally, if you notice the dependency has .vy or .sol contracts and you are missing those from
How to verify it
Checklist