-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade pandas #2136
chore: upgrade pandas #2136
Conversation
@@ -103,7 +103,7 @@ | |||
"ipython>=8.18.1,<9", | |||
"lazyasd>=0.1.4", | |||
"packaging>=23.0,<24", | |||
"pandas>=1.3.0,<2", | |||
"pandas>=2.2.2,<3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the install only take 1 minute now on Python 3.12 so i think this fixes it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have python3.11 failures, I also worry about API changes from 1.x.x to 2.x.x. There's quite a bit of deprecating that's happened between the versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failures are unrelated flaky tests I have been seeing all day. My attempt at de-flaking is here.
Re: the deprecating pandas stuff, maybe a quick audit would help! I am not sure how much we are using any pandas features. I know we use some dataframes but for the most part we create them and return them to the user, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at this doesn't seem too much critical we should worry about
https://pandas.pydata.org/docs/whatsnew/v2.0.0.html#deprecations
@@ -103,7 +103,7 @@ | |||
"ipython>=8.18.1,<9", | |||
"lazyasd>=0.1.4", | |||
"packaging>=23.0,<24", | |||
"pandas>=1.3.0,<2", | |||
"pandas>=2.2.2,<3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at this doesn't seem too much critical we should worry about
https://pandas.pydata.org/docs/whatsnew/v2.0.0.html#deprecations
What I did
see what it do
How I did it
How to verify it
Checklist