Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade pandas #2136

Merged
merged 2 commits into from
Jun 13, 2024
Merged

chore: upgrade pandas #2136

merged 2 commits into from
Jun 13, 2024

Conversation

antazoey
Copy link
Member

What I did

see what it do

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey requested a review from johnson2427 June 13, 2024 14:39
@@ -103,7 +103,7 @@
"ipython>=8.18.1,<9",
"lazyasd>=0.1.4",
"packaging>=23.0,<24",
"pandas>=1.3.0,<2",
"pandas>=2.2.2,<3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the install only take 1 minute now on Python 3.12 so i think this fixes it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have python3.11 failures, I also worry about API changes from 1.x.x to 2.x.x. There's quite a bit of deprecating that's happened between the versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failures are unrelated flaky tests I have been seeing all day. My attempt at de-flaking is here.

Re: the deprecating pandas stuff, maybe a quick audit would help! I am not sure how much we are using any pandas features. I know we use some dataframes but for the most part we create them and return them to the user, I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at this doesn't seem too much critical we should worry about
https://pandas.pydata.org/docs/whatsnew/v2.0.0.html#deprecations

@antazoey antazoey marked this pull request as ready for review June 13, 2024 16:06
@@ -103,7 +103,7 @@
"ipython>=8.18.1,<9",
"lazyasd>=0.1.4",
"packaging>=23.0,<24",
"pandas>=1.3.0,<2",
"pandas>=2.2.2,<3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking at this doesn't seem too much critical we should worry about
https://pandas.pydata.org/docs/whatsnew/v2.0.0.html#deprecations

@antazoey antazoey merged commit a7a501c into ApeWorX:main Jun 13, 2024
15 checks passed
@antazoey antazoey deleted the chore/upgrade-pandas branch June 13, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants