feat: allow comparing currency values to currency strings

[antazoey]

What I did

def test_balance(accounts):
    acct = accounts[0]
    # Before
    assert acct.balance == convert("1000000 ETH", int)
    # After
    assert acct.balance == "1000000 ETH"

fixes: #324

How I did it

super simple int wrapper in a couple cases

How to verify it

Checklist

• All changes are completed
• New test cases have been added
• Documentation has been updated

[fubuloubu]

👀

[banteg]

do i read it right it only works with account.balance? what would it take to make it also work with contract call return values like token.balanceOf?

[antazoey]

do i read it right it only works with account.balance? what would it take to make it also work with contract call return values like token.balanceOf?

We would have to detect balanceOf name in the ABI and wrap it CurrencyValue during the result.
Alternatively, can make the name of CurrencyValue more generic like CurrencyComparable and just wrap all return data ints in that.

[banteg]

yeah i think it's the best to just make every int support this

[antazoey]

yeah i think it's the best to just make every int support this

I don't think we can make every int support this though, without modifying python or something?
We can make every int returned from decode_returndata() handle this tho

[fubuloubu]

I think adding comparison of return values to values decoded by the conversion manager for types like int will satisfy 90% of the use cases

We already have custom __eq__ methods for things like structs, I think only Decimal would be the other python type to handle, maybe AddressType might also be useful e.g. assert c.owner() == "ychad.eth"
https://github.com/ApeWorX/ape/blob/main/src/ape/managers/converters.py#L260-L275

[banteg]

We can make every int returned from decode_returndata() handle this tho

yes, sure, i meant exactly this. and ints in events too.