fix: issue where could not define custom networks in any non-local project #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Jun 19, 2024
antazoey
force-pushed
the
fix/custom-nets-non-local-proj
branch
from
efa7639 to
fb6792a
Compare
antazoey
force-pushed
the
fix/custom-nets-non-local-proj
branch
from
7328443 to
5b93767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I need this fix to fix something else I am working on...
basically there was an issue where any custom network defined in a non-local project was not recognized by Ape.
See my test I added to see what I mean. That failed before but now it does not.
How I did it
How to verify it
Checklist