Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: make ape test --help faster #2368

Merged
merged 2 commits into from
Nov 1, 2024
Merged

perf: make ape test --help faster #2368

merged 2 commits into from
Nov 1, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 1, 2024

What I did

before:

ape test --help  1.59s user 0.20s system 99% cpu 1.803 total

now:

ape test --help  1.27s user 0.17s system 98% cpu 1.461 total

note: the time of ape test --help (e.g. pytest --help) largely depends on so many other things - conftests, plugins, etc.

How I did it

move watch stuff out of cli directly and have it locally imported

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey enabled auto-merge (squash) November 1, 2024 21:50
@antazoey antazoey merged commit f8edd7c into ApeWorX:main Nov 1, 2024
16 checks passed
@antazoey antazoey deleted the perf/test-cmd-still-slow branch November 1, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu