Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with Block transactions when block.hash was None #2426

Merged
merged 6 commits into from
Dec 19, 2024
Merged

fix: issue with Block transactions when block.hash was None #2426

merged 6 commits into from
Dec 19, 2024

Conversation

antazoey
Copy link
Member

What I did

Got a weird error in my boa provider because dont have hashes yet for blocks, tracked it down to the transactions.
Also fixed repr so wouldnt even need to bother with txns during repr. double fix...

How to verify it

block.hash = None
repr(block)
block.transactions

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title fix: issue with Block transactions when .hash was None fix: issue with Block transactions when block.hash was None Dec 19, 2024
@antazoey antazoey enabled auto-merge (squash) December 19, 2024 23:02
@antazoey antazoey merged commit 835e1a0 into ApeWorX:main Dec 19, 2024
18 checks passed
@antazoey antazoey deleted the fix/block-repr-no-hash branch December 20, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotPeopling2day NotPeopling2day NotPeopling2day approved these changes

@bitwise-constructs bitwise-constructs bitwise-constructs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antazoey @bitwise-constructs @NotPeopling2day @fudancoder