Don't build the Ember app twice #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also decrease the time it takes to deploy. |
|
nice 👏 |
|
I love you. |
|
+1000 I reported something similar before but didn't really get any help from the ember-cli-rails people: tricknotes/ember-cli-rails#124 |
|
You'll probably want to enable |
|
@egh nice catch! |
added 2 commits
August 31, 2015 11:52
We were seeing many repeated builds while running the app locally. When we started seeing repeated builds while running tests, that was the final straw. After some investigation, we ended up at the EmberCli Rails gem as the culprit. It was recently discovered that the `ember-cli-uglify` addon was causing lots of duplicated work to be done. More details can be found in the original issue: github.com/tricknotes/ember-cli-rails/issues/184 The EmberCli Rails README has even been updated to advise this: github.com/rwz/ember-cli-rails#experiencing-slow-builddeploy-times This has reduced the local build time from 40+ seconds to 12 seconds. We no longer see duplicate builds happening. Watchman no longer throws many thousands of errors about recrawling the tree.
This was previously turned off, since we were using the ember-cli-uglifier addon. Now that this is removed, we should rely on Rails for all asset compression.
neo-tahi
force-pushed
the
you-only-build-once
branch
from
2fd5493 to
c64b802
Compare
surfacedamage
added a commit
that referenced
this pull request
Aug 31, 2015
Don't build the Ember app twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing many repeated builds while running the app locally. When
we started seeing repeated builds while running tests, that was the
final straw. After some investigation, we ended up at the EmberCli Rails
gem as the culprit.
It was recently discovered that the
ember-cli-uglifyaddon was causinglots of duplicated work to be done.
More details can be found in the original issue:
github.com/tricknotes/ember-cli-rails/issues/184
The EmberCli Rails README has even been updated to advise this:
github.com/rwz/ember-cli-rails#experiencing-slow-builddeploy-times
This has reduced the local build time from 40+ seconds to 12 seconds.
We no longer see duplicate builds happening. Watchman no longer throws
many thousands of errors about recrawling the tree.