Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade react-router-dom from 6.28.1 to 7.1.3 #348

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

guibranco
Copy link
Member

@guibranco guibranco commented Feb 11, 2025

User description

snyk-top-banner

Snyk has created this PR to upgrade react-router-dom from 6.28.1 to 7.1.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


⚠️ Warning: This PR contains major version upgrade(s), and may be a breaking change.

  • The recommended version is 26 versions ahead of your current version.

  • The recommended version was released 24 days ago.

Release notes
Package name: react-router-dom
  • 7.1.3 - 2025-01-17

    See the changelog for release notes: https://github.com/remix-run/react-router/blob/main/CHANGELOG.md#v713

  • 7.1.3-pre.0 - 2025-01-17

    [email protected]

  • 7.1.2 - 2025-01-16
  • 7.1.2-pre.0 - 2025-01-14
  • 7.1.1 - 2024-12-23
  • 7.1.1-pre.0 - 2024-12-21
  • 7.1.0 - 2024-12-20
  • 7.1.0-pre.0 - 2024-12-18
  • 7.0.2 - 2024-12-03
  • 7.0.2-pre.0 - 2024-12-02
  • 7.0.1 - 2024-11-22
  • 7.0.1-pre.0 - 2024-11-22
  • 7.0.0 - 2024-11-22
  • 7.0.0-pre.6 - 2024-11-19
  • 7.0.0-pre.5 - 2024-11-05
  • 7.0.0-pre.4 - 2024-10-29
  • 7.0.0-pre.3 - 2024-10-29
  • 7.0.0-pre.2 - 2024-10-23
  • 7.0.0-pre.1 - 2024-10-11
  • 7.0.0-pre.0 - 2024-10-03
  • 6.29.0 - 2025-01-30
  • 6.29.0-pre-v6.2 - 2025-01-29
  • 6.28.3-pre-v6.1 - 2025-01-28
  • 6.28.3-pre-v6.0 - 2025-01-28
  • 6.28.2 - 2025-01-16
  • 6.28.2-pre.0 - 2025-01-14
  • 6.28.1 - 2024-12-20
from react-router-dom GitHub release notes

Important

  • Warning: This PR contains a major version upgrade, and may be a breaking change.
  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Note

I'm currently writing a description for your pull request. I should be done shortly (<1 minute). Please don't edit the description field until I'm finished, or we may overwrite each other. If I find nothing to write about, I'll delete this message.


Description

  • Upgraded react-router-dom to version 7.1.3, which includes new features and improvements.
  • This upgrade may introduce breaking changes; please review the release notes for details.
  • Updated related dependencies to ensure compatibility with the new version.

Changes walkthrough 📝

Relevant files
Enhancement
package-lock.json
Upgrade react-router-dom and related dependencies               

package-lock.json

  • Upgraded react-router-dom from version 6.28.1 to 7.1.3.
  • Updated react-router dependency to version 7.1.3.
  • Added new dependencies: @types/cookie, cookie, set-cookie-parser, and
    turbo-stream.
  • Adjusted peer dependencies for react and react-dom to require version
    >=18.
  • +50/-24 
    package.json
    Update react-router-dom version in package.json                   

    package.json

  • Changed react-router-dom version from 6.28.1 to 7.1.3.
  • Updated react-router version to 7.1.3.
  • +1/-1     

    💡 Penify usage:
    Comment /help on the PR to get a list of all available Penify tools and their descriptions

    Snyk has created this PR to upgrade react-router-dom from 6.28.1 to 7.1.3.
    
    See this package in npm:
    react-router-dom
    
    See this project in Snyk:
    https://app.snyk.io/org/guibranco/project/b88b735d-6ceb-4bcd-8938-ff5fa1ba73c4?utm_source=github&utm_medium=referral&page=upgrade-pr
    Copy link

    The files' contents are under analysis for test generation.

    Copy link

    sourcery-ai bot commented Feb 11, 2025

    Reviewer's Guide by Sourcery

    This pull request upgrades the 'react-router-dom' dependency from version 6.28.1 to 7.1.3. The update is implemented by modifying the package.json dependency version, which subsequently triggers changes in the package-lock.json. As this is a major version upgrade, it might introduce breaking changes that need to be verified through proper testing.

    Flow Diagram for react-router-dom Upgrade

    graph TD
        A[Start Upgrade]
        B[Update package.json dependency from ^6.28.1 to ^7.1.3]
        C[Automatically update package-lock.json]
        D{Potential Breaking Changes?}
        E[Run tests & verify behavior]
        F[Merge changes]
    
        A --> B
        B --> C
        C --> D
        D -- Yes --> E
        D -- No --> F
    
    Loading

    File-Level Changes

    Change Details Files
    Upgrade major version of react-router-dom dependency
    • Updated the version in package.json from '^6.28.1' to '^7.1.3'
    • Triggered corresponding updates in package-lock.json to lock the new version
    package.json
    package-lock.json

    Tips and commands

    Interacting with Sourcery

    • Trigger a new review: Comment @sourcery-ai review on the pull request.
    • Continue discussions: Reply directly to Sourcery's review comments.
    • Generate a GitHub issue from a review comment: Ask Sourcery to create an
      issue from a review comment by replying to it. You can also reply to a
      review comment with @sourcery-ai issue to create an issue from it.
    • Generate a pull request title: Write @sourcery-ai anywhere in the pull
      request title to generate a title at any time. You can also comment
      @sourcery-ai title on the pull request to (re-)generate the title at any time.
    • Generate a pull request summary: Write @sourcery-ai summary anywhere in
      the pull request body to generate a PR summary at any time exactly where you
      want it. You can also comment @sourcery-ai summary on the pull request to
      (re-)generate the summary at any time.
    • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
      request to (re-)generate the reviewer's guide at any time.
    • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
      pull request to resolve all Sourcery comments. Useful if you've already
      addressed all the comments and don't want to see them anymore.
    • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
      request to dismiss all existing Sourcery reviews. Especially useful if you
      want to start fresh with a new review - don't forget to comment
      @sourcery-ai review to trigger a new review!
    • Generate a plan of action for an issue: Comment @sourcery-ai plan on
      an issue to generate a plan of action for it.

    Customizing Your Experience

    Access your dashboard to:

    • Enable or disable review features such as the Sourcery-generated pull request
      summary, the reviewer's guide, and others.
    • Change the review language.
    • Add, remove or edit custom review instructions.
    • Adjust other review settings.

    Getting Help

    @guibranco guibranco enabled auto-merge (squash) February 11, 2025 05:00
    Copy link

    coderabbitai bot commented Feb 11, 2025

    Important

    Review skipped

    Ignore keyword(s) in the title.

    Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

    You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


    🪧 Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>, please review it.
      • Generate unit testing code for this file.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
      • @coderabbitai generate unit testing code for this file.
      • @coderabbitai modularize this function.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
      • @coderabbitai read src/utils.ts and generate unit testing code.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
      • @coderabbitai help me debug CodeRabbit configuration file.

    Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

    CodeRabbit Commands (Invoked using PR comments)

    • @coderabbitai pause to pause the reviews on a PR.
    • @coderabbitai resume to resume the paused reviews.
    • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
    • @coderabbitai full review to do a full review from scratch and review all the files again.
    • @coderabbitai summary to regenerate the summary of the PR.
    • @coderabbitai generate docstrings to generate docstrings for this PR.
    • @coderabbitai resolve resolve all the CodeRabbit review comments.
    • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
    • @coderabbitai help to get help.

    Other keywords and placeholders

    • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
    • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
    • Add @coderabbitai anywhere in the PR title to generate the title automatically.

    CodeRabbit Configuration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Documentation and Community

    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

    @gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Feb 11, 2025
    Copy link

    @sourcery-ai sourcery-ai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We have skipped reviewing this pull request. It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!

    @github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 11, 2025
    @penify-dev penify-dev bot added the enhancement New feature or request label Feb 11, 2025
    Copy link

    @korbit-ai korbit-ai bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I've completed my review and didn't find any issues.

    Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

    Korbit Guide: Usage and Customization

    Interacting with Korbit

    • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
    • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
    • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
    • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
    • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

    Customizing Korbit

    • Check out our docs on how you can make Korbit work best for you and your team.
    • Customize Korbit for your organization through the Korbit Console.

    Current Korbit Configuration

    General Settings
    Setting Value
    Review Schedule Automatic excluding drafts
    Max Issue Count 10
    Automatic PR Descriptions
    Issue Categories
    Category Enabled
    Documentation
    Logging
    Error Handling
    Readability
    Design
    Performance
    Security
    Functionality

    Feedback and Support

    Note

    Korbit Pro is free for open source projects 🎉

    Looking to add Korbit to your team? Get started with a free 2 week trial here

    Copy link
    Contributor

    penify-dev bot commented Feb 11, 2025

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are primarily version upgrades with minimal code changes, but testing is necessary to ensure compatibility.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Breaking Change: Upgrading from version 6.x to 7.x may introduce breaking changes that could affect existing functionality. Review the changelog for any necessary adjustments.

    🔒 Security concerns

    No

    Copy link
    Contributor

    penify-dev bot commented Feb 11, 2025

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Maintain consistency between package.json and package-lock.json for the new dependency version

    Ensure that the version of "react-router-dom": "^7.1.3" is reflected in both package.json
    and package-lock.json to maintain consistency.

    package.json [16]

    -"react-router-dom": "^7.1.3",
    +"react-router-dom": "^7.1.3", // Ensure consistency with package-lock.json
     
    Suggestion importance[1-10]: 9

    Why: Maintaining consistency between these files is important for dependency management, and this suggestion directly addresses that need.

    9
    Compatibility
    Verify compatibility of the new version with existing dependencies

    Ensure that the upgrade to "react-router-dom": "^7.1.3" is compatible with the rest of the
    dependencies, especially "react" and "react-dom", which are both at version "^19.0.0".

    package-lock.json [20]

    -"react-router-dom": "^7.1.3",
    +"react-router-dom": "^7.1.3", // Ensure compatibility with react and react-dom
     
    Suggestion importance[1-10]: 8

    Why: This suggestion addresses a crucial aspect of dependency management, ensuring that the new version of "react-router-dom" is compatible with existing dependencies.

    8
    Testing
    Execute tests to confirm that routing works correctly after the upgrade

    After upgrading "react-router-dom", run tests to ensure that all routing functionalities
    are working as expected.

    package-lock.json [20]

    -"react-router-dom": "^7.1.3",
    +"react-router-dom": "^7.1.3", // Run tests to verify routing functionality
     
    Suggestion importance[1-10]: 8

    Why: Running tests after an upgrade is essential to confirm that the application behaves as expected, making this a valuable suggestion.

    8
    Best practice
    Review the release notes for potential breaking changes in the new version

    Consider checking the release notes for "react-router-dom" version 7.1.3 to identify any
    breaking changes that may affect your application.

    package-lock.json [20]

    -"react-router-dom": "^7.1.3",
    +"react-router-dom": "^7.1.3", // Check release notes for breaking changes
     
    Suggestion importance[1-10]: 7

    Why: This is a good practice to avoid potential issues, but it is more of a precautionary measure rather than a critical change.

    7

    @guibranco
    Copy link
    Member Author

    @gstraccini npm check updates

    Copy link
    Contributor

    gstraccini bot commented Feb 21, 2025

    Running the command npm-check-updates to update dependencies via NPM! 🏗️

    Copy link
    Contributor

    gstraccini bot commented Feb 21, 2025

    NPM check updates result:

    Upgrading /home/runner/work/gstraccini-bot-workflows/gstraccini-bot-workflows/package.json
    
    
     react-router-dom  ^7.1.3  →  ^7.2.0
    
    Run npm install to install new versions.
    npm warn deprecated [email protected]: Please use @jridgewell/sourcemap-codec instead
    npm warn deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
    npm warn deprecated [email protected]: [email protected]
    npm warn deprecated [email protected]: It is not compatible with newer versions of GA starting with v4, as long as you are using GAv3 it should be ok, but the package is not longer being maintained
    npm warn deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
    npm warn deprecated [email protected]: You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other.
    npm warn deprecated
    npm warn deprecated (For a CapTP with native promises, see @endo/eventual-send and @endo/captp)
    npm warn deprecated [email protected]: Use your platform's native performance.now() and performance.timeOrigin.
    npm warn deprecated [email protected]: Use your platform's native DOMException instead
    npm warn deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
    npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
    npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
    npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
    npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
    npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
    npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-methods instead.
    npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-numeric-separator instead.
    npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
    npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
    npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
    npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.
    npm warn deprecated [email protected]: This SVGO version is no longer supported. Upgrade to v2.x.x.
    npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
    
    added 1383 packages, and audited 1384 packages in 36s
    
    268 packages are looking for funding
      run `npm fund` for details
    
    12 vulnerabilities (6 moderate, 6 high)
    
    To address all issues (including breaking changes), run:
      npm audit fix --force
    
    Run `npm audit` for details.
    
    changed 1 package, and audited 1384 packages in 2s
    
    268 packages are looking for funding
      run `npm fund` for details
    
    12 vulnerabilities (6 moderate, 6 high)
    
    To address all issues (including breaking changes), run:
      npm audit fix --force
    
    Run `npm audit` for details.
    
    

    @github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2025
    Copy link

    socket-security bot commented Feb 21, 2025

    🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

    To accept the risk, merge this PR and you will not be notified again.

    Alert Package NoteCI
    Filesystem access npm/[email protected] 🚫
    New author npm/[email protected] 🚫
    Unpopular package npm/[email protected] 🚫
    Unstable ownership npm/[email protected] 🚫

    View full report↗︎

    Next steps

    What is filesystem access?

    Accesses the file system, and could potentially read sensitive data.

    If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

    What is new author?

    A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

    Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

    What are unpopular packages?

    This package is not very popular.

    Unpopular packages may have less maintenance and contain other problems.

    What is unstable ownership?

    A new collaborator has begun publishing package versions. Package stability and security risk may be elevated.

    Try to reduce the number of authors you depend on to reduce the risk to malicious actors gaining access to your supply chain. Packages should remove inactive collaborators with publishing rights from packages on npm.

    Take a deeper look at the dependency

    Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

    Remove the package

    If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

    Mark a package as acceptable risk

    To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

    @guibranco
    Copy link
    Member Author

    @gstraccini rerun workflows cancelled

    Copy link
    Contributor

    gstraccini bot commented Feb 21, 2025

    Rerunning 4 cancelled workflows on the commit d9dedb0449fe8a24dc8bc858939d5a85acc068d1! 🔁

    Copy link
    Contributor

    gstraccini bot commented Feb 21, 2025

    Rerunning the following workflows:

    Copy link

    Infisical secrets check: ✅ No secrets leaked!

    💻 Scan logs
    11:21AM INF scanning for exposed secrets...
    11:21AM INF 467 commits scanned.
    11:21AM INF scan completed in 1.17s
    11:21AM INF no leaks found
    

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) enhancement New feature or request Review effort [1-5]: 2 size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants