Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Commit

Permalink
Only send notifications on push, not on PRs
Browse files Browse the repository at this point in the history
  • Loading branch information
EricWittmann committed Nov 20, 2023
1 parent 231a658 commit 565f223
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/verify.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ jobs:
quay.io/${{env.IMAGE_ORG}}/apicurio-api-designer-ui:${{env.IMAGE_TAG}}
- name: Google Chat Notification (Always)
if: always()
if: github.event_name == 'push' && always()
uses: Co-qn/google-chat-notification@b9227d9daa4638c9782a5bd16c4abb86268127a1
with:
name: ${{ github.job }}
url: ${{ secrets.GOOGLE_CHAT_WEBHOOK }}
status: ${{ job.status }}

- name: Google Chat Notification (Error)
if: failure()
if: github.event_name == 'push' && failure()
uses: Co-qn/google-chat-notification@b9227d9daa4638c9782a5bd16c4abb86268127a1
with:
name: ${{ github.job }}
Expand Down
6 changes: 3 additions & 3 deletions ui/ui-app/src/services/NavigationService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ export const useNavigation: () => NavigationService = (): NavigationService => {
const svcConfig: ServiceConfig = useServiceConfig();

return {
navigateTo: (path: string) => {
return navigateTo(path, svcConfig, navigate);
navigateTo: (path: string): void => {
navigateTo(path, svcConfig, navigate);
},
createLink: (path: string) => {
createLink: (path: string): string => {
return `${svcConfig.navigation.basename}${path}`;
},
};
Expand Down

0 comments on commit 565f223

Please sign in to comment.