Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support user-provided pod template (PodSpec) in the ApicurioRegistry CRD (preview feature) #212

Merged
merged 1 commit into from
Jun 6, 2023
Merged

feat: support user-provided pod template (PodSpec) in the ApicurioRegistry CRD (preview feature) #212

merged 1 commit into from
Jun 6, 2023

Conversation

jsenko
Copy link
Member

@jsenko jsenko commented May 29, 2023

andreaTP
andreaTP requested changes May 30, 2023
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @jsenko added a few comments 🙂

api/v1/apicurioregistry_types.go Outdated Show resolved Hide resolved
api/v1/apicurioregistry_types.go Outdated Show resolved Hide resolved
controllers/cf/cf_pod_spec.go Outdated Show resolved Hide resolved
controllers/cf/cf_pod_spec.go Outdated Show resolved Hide resolved
controllers/cf/cf_pod_spec.go Outdated Show resolved Hide resolved
controllers/cf/cf_pod_spec.go Outdated Show resolved Hide resolved
controllers/cf/cf_pod_spec.go Outdated Show resolved Hide resolved
controllers/cf/cf_pod_spec.go Outdated Show resolved Hide resolved
controllers/cf/cf_pod_spec.go Outdated Show resolved Hide resolved
controllers/svc/factory/factory_kube.go Show resolved Hide resolved
@jsenko jsenko force-pushed the support-pod-template branch from 51df7f1 to 8395234 Compare June 6, 2023 08:22
@jsenko jsenko marked this pull request as ready for review June 6, 2023 08:23
@jsenko jsenko merged commit d19e018 into Apicurio:main Jun 6, 2023
@jsenko jsenko deleted the support-pod-template branch June 6, 2023 09:19
This was referenced Jun 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsenko @andreaTP