Migrate the first half of the async demos #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PollyDemos/Async/AsyncDemo05_WaitAndRetryWithExponentialBackoff.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+7
to
+10
| protected int totalRequests; | ||
| protected int eventualSuccesses; | ||
| protected int eventualFailures; | ||
| protected int retries; |
There was a problem hiding this comment.
Let's make these properties with PascalCase naming.
There was a problem hiding this comment.
If you don't mind I would do that renaming as a separate PR after all sync and async demos under the Polly.Demos are migrated.
PollyDemos/Async/AsyncDemo05_WaitAndRetryWithExponentialBackoff.cs
Outdated
Show resolved
Hide resolved
PollyDemos/Async/AsyncDemo05_WaitAndRetryWithExponentialBackoff.cs
Outdated
Show resolved
Hide resolved
…f.cs Co-authored-by: Martin Costello <[email protected]>
martincostello
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SyncDemotoDemoBase