Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use [DebuggerDisableUserUnhandledExceptions] #2254

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Use [DebuggerDisableUserUnhandledExceptions] #2254

merged 2 commits into from
Oct 16, 2024

Commits on Oct 16, 2024

  1. Use [DebuggerDisableUserUnhandledExceptions] 

    - Add usage of `[DebuggerDisableUserUnhandledExceptions]` in `StrategyHelper` and `RetryEngine` to avoid newer versions of the Visual Studio debugger for breaking for exceptions we are intentionally handling.
- Add copy of `[DebuggerDisableUserUnhandledExceptions]` for use in downlevel versions of .NET that do not contain the attribute.
- Add `net9.0` TFM to potentially include to use the built-in definition of the attribute.
- Add `net8.0` TFM to Polly to resolve dependency resolution issues in the Snippets project.
    @martincostello
    martincostello committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dce141d View commit details
    Browse the repository at this point in the history

  2. Remove net9.0 TFM from packages 

    Remove the `net9.0` TFM from the Polly.* assemblies to see if we can still get the utility of the new debugger feature in a `net9.0` host without the matching TFM for the Polly NuGet packages.
    @martincostello
    martincostello committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    704cd7e View commit details
    Browse the repository at this point in the history