Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signing workflow #2323

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Update signing workflow #2323

merged 2 commits into from
Oct 1, 2024

Conversation

martincostello
Copy link
Member

  • Update AuthenticodeLint to a version targeting .NET 8.
  • Set environment variables for Azure Key Vault to use with future versions of the sign tool.

Tested in #2322.

Update to a version targeting .NET 8.
Set environment variables for Azure Key Vault to use with future versions of the `sign` tool.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code github_actions Pull requests that update GitHub Actions code labels Oct 1, 2024
@martincostello martincostello added this to the v8.4.3 milestone Oct 1, 2024
@martincostello martincostello enabled auto-merge (rebase) October 1, 2024 11:58
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (0969c55) to head (23e17ac).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2323   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         313      313           
  Lines        7461     7461           
  Branches     1126     1126           
=======================================
  Hits         6371     6371           
  Misses        745      745           
  Partials      345      345           
Flag Coverage Δ
linux 85.39% <ø> (+0.02%) ⬆️
macos 85.36% <ø> (-0.03%) ⬇️
windows 85.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 056b27c into main Oct 1, 2024
18 checks passed
@martincostello martincostello deleted the update-signing branch October 1, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement github_actions Pull requests that update GitHub Actions code .NET Pull requests that update .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant