[Fix] Snap Dto 통합 #116 #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parseyong
requested changes
Jul 20, 2024
Comment on lines
57
to
+58
| @Parameters({ | ||
| @Parameter(name = "targetLoginId" , description = "친구목록을 조회할 유저의 loginId", required = true,example = "tempLoginId"), | ||
| @Parameter(name = "targetLoginId" , description = "친구목록을 조회할 유저의 writerLoginId", required = true,example = "tempLoginId"), |
There was a problem hiding this comment.
인텔리제이 refactor기능 이용하면 자주 이러는데 loginId 변수명 바뀔 때 다른 코드의 loginId도 같이 바뀐거같아요. 다른 부분도 많이 바뀐거같아서 변경기록보고 수정해야할거같아요
There was a problem hiding this comment.
이런.. 그냥 close 하고 처음부터 다시 수정해야겠네
| public record FindSnapResDto( | ||
| public record AlbumSnapResDto( |
There was a problem hiding this comment.
스냅dto를 하나로 합치는거면 둘중에 dto하나는 나중에 삭제하는건가요?
There was a problem hiding this comment.
아니야 하나는 앨범 전체 조회시 조회되는 Dto로 남게 될거야
Comment on lines
20
to
25
| String userUid = null; | ||
| String userName = null; | ||
| if (entity.getUser() != null) { | ||
| userUid = entity.getUser().getLoginId(); | ||
| userName = entity.getUser().getName(); | ||
| } |
There was a problem hiding this comment.
스냅에 연결된 유저가 null인 경우는 없어서 이부분은 불필요한거같습니다.
Comment on lines
+47
to
65
| public static SnapResInfo toDto(Snap result, String profilePhotoURL, String snapPhotoURL, | ||
| List<FindTagUserResDto> findTagUserList, Long likeCnt, boolean isLikedSnap){ | ||
|
|
||
| return SnapResInfo.builder() | ||
| .snapId(result.getId()) | ||
| .oneLineJournal(result.getOneLineJournal()) | ||
| .snapPhotoURL(snapPhotoURL) | ||
| .snapCreatedDate(result.getCreatedDate()) | ||
| .snapModifiedDate(result.getLastModifiedDate()) | ||
| .writerLoginId(result.getUser().getLoginId()) | ||
| .profilePhotoURL(profilePhotoURL) | ||
| .writerUserName(result.getUser().getName()) | ||
| .findTagUserList(findTagUserList) | ||
| .likeCnt(likeCnt) | ||
| .isLikedSnap(isLikedSnap) | ||
| .build(); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
지금 똑같은 정적메소드가 두개생성된거같아요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 이슈 번호
close #116
🛠 구현 사항
SnapPagingInfo -> SnapResInfo로 이름 변경하였음
FindSnapResDto -> AlbumSnapResDto로 이름 변경하였음
📚 기타