Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RoundedBar renderer for corner radius positive/negative BarChart #239

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

hannesa2
Copy link
Collaborator

… corner radius positive/negative Bar Chart

It's PhilJay#5420

close #237

@hannesa2
Copy link
Collaborator Author

@Paget96

PhilJay#5420 (comment)

There is crash when we use FloatArray for Y values.
Crash happens here, as we don't have y, instead yVals

if ((dataSet.getEntryForIndex(j / 4).y < 0 && roundedNegativeDataSetRadius > 0)) {

This is only needed to make it perfect

Where should be this applied ? Best would be a pull request

@hannesa2 hannesa2 changed the title Added RoundedBarChartRenderer & RoundedHorizontalBarChartRenderer for… Add RoundedBar renderer for corner radius positive/negative BarChart Jun 22, 2024
@hannesa2 hannesa2 force-pushed the bar-rounded-corners branch 2 times, most recently from 2eb323c to 485fe85 Compare June 22, 2024 06:03
@hannesa2
Copy link
Collaborator Author

Screenshot differs: 1

StartTest_smokeTestStart-20-PieChartActivity.pngscreenshot

@Paget96
Copy link

Paget96 commented Jun 22, 2024

@Paget96

PhilJay#5420 (comment)

There is crash when we use FloatArray for Y values.
Crash happens here, as we don't have y, instead yVals

if ((dataSet.getEntryForIndex(j / 4).y < 0 && roundedNegativeDataSetRadius > 0)) {

This is only needed to make it perfect

Where should be this applied ? Best would be a pull request

It's for values on the bar chart. You can find this in the renderer file.

@hannesa2
Copy link
Collaborator Author

It's for values on the bar chart. You can find this in the renderer file.

Sure. But current line differs. Is this the "shall be" or "current is" ?
I'm confused

@hannesa2 hannesa2 force-pushed the bar-rounded-corners branch 4 times, most recently from 41c135d to 9504fd1 Compare June 23, 2024 07:38
@hannesa2 hannesa2 force-pushed the bar-rounded-corners branch from 9504fd1 to 858233b Compare June 24, 2024 07:17
@hannesa2 hannesa2 force-pushed the bar-rounded-corners branch from 858233b to 814de5e Compare June 24, 2024 07:36
@hannesa2
Copy link
Collaborator Author

This is the new test
image

@hannesa2 hannesa2 merged commit 9043118 into master Jun 24, 2024
2 checks passed
@hannesa2 hannesa2 deleted the bar-rounded-corners branch June 24, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounded bar chart renderer
2 participants