Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR #39 add functionality of home and end hotkeys on web version #43

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

PAVANNAIK25
Copy link
Contributor

Description

This PR adds functionality of home and end keys on web version. Earlier it was not working properly. This PR is created against FR #39 . It does not need the adding or updating tests.


Checklist

General

  • I've included relevant documentation or comments for the changes introduced.
  • I've tested the changes in multiple environments (e.g., different browsers, operating systems).

Testing

  • I've added or updated tests to validate the changes introduced for AppFlowy Web.

Feature-Specific

  • For feature additions, I've added a preview (video, screenshot, or demo) in the "Feature Preview" section.
  • I've verified that this feature integrates seamlessly with existing functionality.

@PAVANNAIK25
Copy link
Contributor Author

Hi,

It seems like Web code coverage has failed. Please let me know if there is anything I can to do to fix it.

@khorshuheng
Copy link
Collaborator

Thanks for the PR, could you format/lint the modified file based on https://github.com/AppFlowy-IO/AppFlowy-Web/blob/main/.prettierrc.cjs ?

@PAVANNAIK25
Copy link
Contributor Author

@khorshuheng I have ran format and lint commands on the files. No changes found. If there is anything else, please feel free to tell me.

@khorshuheng
Copy link
Collaborator

You were correct - seems like the original source file wasn't formatted based on .prettierrc,csj . I will probably need to format the two files in this PR and merge it to the main branch first, so that it's easier for the reviewer to visualize what has been changed in this PR, that fixed the issue.

@PAVANNAIK25
Copy link
Contributor Author

You were correct - seems like the original source file wasn't formatted based on .prettierrc,csj . I will probably need to format the two files in this PR and merge it to the main branch first, so that it's easier for the reviewer to visualize what has been changed in this PR, that fixed the issue.

okay, thank you @khorshuheng

@PAVANNAIK25
Copy link
Contributor Author

Hi @khorshuheng,
Could you please provide an update on when this PR might be merged? I'm using AppFlowy Web and am still experiencing this issue.

@khorshuheng
Copy link
Collaborator

@PAVANNAIK25 Most of our team members are on leave this week, so unfortunately, the earliest that we can merge this is probably next week.

However, if the purpose is to unblock your own deployment, you can build your own image via https://github.com/AppFlowy-IO/AppFlowy-Cloud/tree/main/docker/web . You will just need to replace this line with your own repository: https://github.com/AppFlowy-IO/AppFlowy-Cloud/blob/950563dbefde02a9276b82b0b6ce08e26f70e275/docker/web/Dockerfile#L8

@PAVANNAIK25
Copy link
Contributor Author

@khorshuheng Thank you for the update!

@qinluhe qinluhe merged commit 7b13cf7 into AppFlowy-IO:main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants